Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name #32

Closed
mem48 opened this issue Jan 21, 2020 · 8 comments
Closed

Package name #32

mem48 opened this issue Jan 21, 2020 · 8 comments

Comments

@mem48
Copy link
Contributor

mem48 commented Jan 21, 2020

geofabric or geofabrik https://www.geofabrik.de/data/download.html

@Robinlovelace
Copy link
Member

Personally I like geofabric. It's a cool name its own right (for downloading OSM data, the fabric of open geo data) but not too tied to the geofabik service, an ideal balance IMO that would still stand if that service went down.

@Robinlovelace
Copy link
Member

Thoughts @agila5 ?

@agila5
Copy link
Contributor

agila5 commented Jan 21, 2020

I would change the package name to "geofabrik" or "geofabRik" or something like that. I don't see any problem changing the package name since there are just a few people using it atm.

Personally I like geofabric. It's a cool name its own right (for downloading OSM data, the fabric of open geo data) but not too tied to the geofabik service, an ideal balance IMO that would still stand if that service went down.

The core idea behind the package is downloading data from geofabrik servers so I don't see the point of this package if that service goes down.

@Robinlovelace
Copy link
Member

Happy to change the name, looks like I've been outvoted! PRs welcome. However this raises the wider question: should we submit this for peer review to rOpenSci. I guess that depends on how much we want to work on it to complete the review. Will almost certainly make the package more user friendly if it does get a peer review. Thoughts?

@agila5
Copy link
Contributor

agila5 commented Jan 22, 2020

Happy to change the name, looks like I've been outvoted! PRs welcome.

Working on that.

However this raises the wider question: should we submit this for peer review to rOpenSci

IMO, yes! I can't focus on this project until mid february but I'd like to submit it for peer review.

@Robinlovelace
Copy link
Member

Re-opening this following the discovery that there are other good extract providers as documented in #38 and discussion with @maelle and others from rOpenSci shown below.

My suggestion in #32 was for the package not to be tied to geofabrik and I think that is a good idea. The package could evolve to include other bulk sources.

I could think of worse names than geofabric for a generic package to dl osm data. If we were to generalise the package, how about osmextract?

👍 for {osmextract} (from what I understand the package does / is supposed to do).

@Robinlovelace
Copy link
Member

Update: I think we should rename it to osmextractr and will open a PR that implements that.

@Robinlovelace
Copy link
Member

Example for readme:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants