Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode URLs #63

Closed
KevCaz opened this issue Nov 1, 2021 · 3 comments
Closed

Encode URLs #63

KevCaz opened this issue Nov 1, 2021 · 3 comments

Comments

@KevCaz
Copy link
Member

KevCaz commented Nov 1, 2021

I am currently not able to test updated_since because of a mismatch between the request and what's recorded

request:

https://api.speciesplus.net/api/v1/taxon_concepts.json?updated_since=2018-01-01T00%3A00%3A00&page=1&per_page=500

and the cassette:

https://api.speciesplus.net/api/v1/taxon_concepts.json?updated_since=2018-01-01T00:00:00&page=1&per_page=500

One possible way around is to use utils::encodeURL()

@KevCaz
Copy link
Member Author

KevCaz commented Nov 2, 2021

Depending on this I may or may not use utils::encode() ropensci/vcr#240

@KevCaz KevCaz reopened this Nov 2, 2021
@KevCaz
Copy link
Member Author

KevCaz commented Nov 4, 2021

There are several good options, can't say they're all as good, but I don't see any major drawback for any of those:

  1. using modify_url() from httr
  2. using curl::curl_escape() which is used at some point by httr::modify_url()
  3. using utils::encode() which I do.

None of them will actually add the dependencies list because the 3 packages area already direct or indirect depencies.

KevCaz pushed a commit that referenced this issue Nov 4, 2021
@KevCaz
Copy link
Member Author

KevCaz commented Nov 6, 2022

This has been fixed in vcr see ropensci/vcr#247.

@KevCaz KevCaz closed this as completed Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant