Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coops changes #126

Closed
sckott opened this issue Dec 23, 2015 · 6 comments
Closed

coops changes #126

sckott opened this issue Dec 23, 2015 · 6 comments
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Dec 23, 2015

@jsta can we change some things

  • change numeric data to numeric class. right now, i think all columns numbers, but given back as character
  • ...
@jsta
Copy link
Contributor

jsta commented Dec 24, 2015

The idea would be to convert character results to numeric? I'll go through the various product results and see how the numeric columns lineup.

@jsta
Copy link
Contributor

jsta commented Dec 24, 2015

Also, I see that calls to water level products should throw an error if a datum is not supplied. Currently there is just a silent "no data" return.

@sckott
Copy link
Contributor Author

sckott commented Dec 24, 2015

The idea would be to convert character results to numeric?

yes

@jsta
Copy link
Contributor

jsta commented Dec 29, 2015

Another issue is that the datums and predictions product return a data.frame not named "data"

@jsta
Copy link
Contributor

jsta commented Dec 29, 2015

Not all of the data columns are numeric for all products. For example, all of the products except for monthly_mean return a character POSIXct date-stamp as the first column.

@sckott
Copy link
Contributor Author

sckott commented Jan 21, 2016

thanks, closing

@sckott sckott closed this as completed Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants