Coerce coops results to numeric, account for data results not named "data", add examples #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #' # Get air temperature at Vaca Key (2723970) | ||
| #' # Get daily mean water level data at Fairport, OH (9063053) | ||
| #' coops_search(station_name = 9063053, begin_date = 20150927, end_date = 20150928, | ||
| #' product = "daily_mean", datum = "stnd"), time_zone = "lst") |
There was a problem hiding this comment.
there's an extra parentheses here datum = "stnd"), time_zone = "lst")
|
can you fix that one thing above, otherwise, looks good |
sckott
added a commit
that referenced
this pull request
Jan 2, 2016
Coerce coops results to numeric, account for data results not named "data", add examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#126 Still unsure if I have coerced numeric results in the best way. The only consistent numeric column across all products is the second column. Here is a breakdown of the various column types: