Fix for gefs tests #319
Merged
Fix for gefs tests #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks having a look |
sckott
suggested changes
Sep 19, 2019
tests/testthat/test-gefs.R
Outdated
| temp = "Temperature_height_above_ground_ens" | ||
|
|
||
| # Get raw and processed data | ||
| d_raw <- gefs(var = temp, |
There was a problem hiding this comment.
I'd like any code in tests that make HTTP requests to be skipped on cran because any http request failure could cause cran maintainers to throw a tantrum
There was a problem hiding this comment.
you can do variable assignment up here but not HTTP requests
There was a problem hiding this comment.
Right, I knew there was a reason I had it differently before. Ultimately I should move those to mock api calls but for now I've moved them inside of the test and put all tests related to the returned data object inside of one test_that() call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the broken gefs test.
Related Issue
#316, #317