Overline doc #405
Merged
Overline doc #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads-up @mem48 this is work in progress. |
|
Looks ok, but hard to tell with all the changes, if the tests pass I suggest merge and the do a human check of the docs to make sure. |
|
Heads-up @mem48 here is the updated merged documentation: https://docs.ropensci.org/stplanr/reference/overline.html |
|
The second paragraph is confusing as it says it is a replacement to itself |
|
Lots of warnings in the examples |
|
That's will be fixed when this is fixed: #364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.