-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use specific env variables #96
base: main
Are you sure you want to change the base?
Conversation
Nice, this quite an annoying missing piece in the documentation. Can I ask why not using |
@Rafnuss Main reason that credential-management systems are not used here is because they are often difficult to use within containerized environments such as Dockerfiles. Direct use of environment variables offers greater flexibility for using this package in a range of computational environments. And @rkrug sorry that I forgot about this PR. You still interested in moving ahead with it? |
No worries. Yes please - I am not using deposits at the moment, but I will use it again. And using these specific names for the end variables would make the handling more robust. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rkrug, and apologies again for leaving this hanging so long. With that minor improvement, it should be good to merge.
e <- Sys.getenv("FIGSHARE_TOKEN") | ||
} | ||
|
||
if (e == "") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (e == "") { | |
if (!nzchar (e)) { |
The code now checks if the environmental variables
are set and reads these. If they are not set, it uses the heuristic algorithm included before.