Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific env variables #96

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rkrug
Copy link

@rkrug rkrug commented Dec 11, 2023

The code now checks if the environmental variables

- ZENOODO_TOKEN
- ZENODO_SANDBOX_TOKEN
- FIGSHARE_TOKEN

are set and reads these. If they are not set, it uses the heuristic algorithm included before.

@Rafnuss
Copy link

Rafnuss commented Jan 10, 2025

Nice, this quite an annoying missing piece in the documentation. Can I ask why not using keyring? Seems like it's quite popular to manage such token? Or maybe not?

@mpadge
Copy link
Member

mpadge commented Jan 13, 2025

@Rafnuss Main reason that credential-management systems are not used here is because they are often difficult to use within containerized environments such as Dockerfiles. Direct use of environment variables offers greater flexibility for using this package in a range of computational environments.

And @rkrug sorry that I forgot about this PR. You still interested in moving ahead with it?

@rkrug
Copy link
Author

rkrug commented Jan 13, 2025

No worries.

Yes please - I am not using deposits at the moment, but I will use it again. And using these specific names for the end variables would make the handling more robust.

Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rkrug, and apologies again for leaving this hanging so long. With that minor improvement, it should be good to merge.

e <- Sys.getenv("FIGSHARE_TOKEN")
}

if (e == "") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (e == "") {
if (!nzchar (e)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants