Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter plugin for exponential filter #231

Merged
merged 9 commits into from
Jan 1, 2025

Conversation

christophfroehlich
Copy link
Contributor

Similar to control_filters/LowPassFilter, the filter itself was already there.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (e1f26e4) to head (3b036df).

Files with missing lines Patch % Lines
include/control_filters/exponential_filter.hpp 0.00% 28 Missing ⚠️
src/control_filters/exponential_filter.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           ros2-master     #231      +/-   ##
===============================================
- Coverage        74.78%   72.75%   -2.04%     
===============================================
  Files               22       25       +3     
  Lines             1071     1101      +30     
  Branches            85       89       +4     
===============================================
  Hits               801      801              
- Misses             222      252      +30     
  Partials            48       48              
Flag Coverage Δ
unittests 72.75% <0.00%> (-2.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/control_filters/exponential_filter.cpp 0.00% <0.00%> (ø)
include/control_filters/exponential_filter.hpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks great.
Thanks for this new filter

@christophfroehlich christophfroehlich merged commit 240d29c into ros2-master Jan 1, 2025
25 of 27 checks passed
@christophfroehlich christophfroehlich deleted the add/exp_filter branch January 1, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants