Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PidROS] Enable interpreting prefix as param prefix. #129

Merged
merged 8 commits into from
Apr 4, 2023

Conversation

destogl
Copy link
Member

@destogl destogl commented Dec 8, 2022

When using PIDController (ros-controls/ros2_controllers#434) as preceeding controller we should not remove "/" from the parameter prefix since this causes a confusion between parameters and how we are defining reference interfaces ("controller_name/interface") in ros2_control.

This enalbes using of parameters prefixes for following interfaces, e.g.:

pid_controller:
  ros__parameters:

    dof_names:
      - following_controller/joint28
      - following_controller/joint23

    ...

    gains:
      following_controller/joint28: {"p": 28.0, "i": 28.0, ...}
      following_controller/joint23: {"p": 23.0, "i": 23.0, ...}

@destogl destogl self-assigned this Dec 8, 2022
@destogl destogl requested a review from bmagyar December 8, 2022 17:57
@destogl destogl force-pushed the add-option-to-define-prefix-as-param-prefix branch from 601276f to 6c90a20 Compare February 14, 2023 16:26
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never used the namespacing stuff to give proper feedback, but the changes look good to me

@destogl
Copy link
Member Author

destogl commented Mar 20, 2023

@bmagyar can we please go on with this?

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only minor changes to doc

include/control_toolbox/pid_ros.hpp Outdated Show resolved Hide resolved
include/control_toolbox/pid_ros.hpp Outdated Show resolved Hide resolved
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also created a follow-up #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants