-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PidROS] Enable interpreting prefix as param prefix. #129
[PidROS] Enable interpreting prefix as param prefix. #129
Conversation
601276f
to
6c90a20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never used the namespacing stuff to give proper feedback, but the changes look good to me
@bmagyar can we please go on with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only minor changes to doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also created a follow-up #156
When using PIDController (ros-controls/ros2_controllers#434) as preceeding controller we should not remove "/" from the parameter prefix since this causes a confusion between parameters and how we are defining reference interfaces ("controller_name/interface") in ros2_control.
This enalbes using of parameters prefixes for following interfaces, e.g.: