Fix bug in rate_limiter filter and add more tests #237
+320
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ros2-master #237 +/- ##
===============================================
+ Coverage 71.05% 74.69% +3.63%
===============================================
Files 20 22 +2
Lines 1040 1071 +31
Branches 84 85 +1
===============================================
+ Hits 739 800 +61
+ Misses 255 223 -32
- Partials 46 48 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions
bot
requested review from
bmagyar,
fmauch,
homalozoa,
mamueluth,
mcbed,
peterdavidfagan and
saikishor
saikishor
reviewed
Nov 22, 2024
Comment on lines
11
to
+15
| default_value: .NAN, | ||
| description: "Maximum value, e.g. [m/s]", | ||
| validation: { | ||
| "control_filters::gt_eq_or_nan<>": [0.0] | ||
| }, |
There was a problem hiding this comment.
Is infinite a better default value here? Or Nan is better?
There was a problem hiding this comment.
in principle you are right, and it would already work setting it + or -infinite. However, NaN is the default value of the diff_drive_controller. And the logic of "copying the positive value if negative is not given" would not work because infinite is a valid limit 🤔
christophfroehlich
force-pushed
the
test/rate_limiter
branch
from
a617a42
to
d984267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran in the same issue as was solved with diff_drive_controller already ros-controls/ros2_controllers#252
I added some tests, and furthermore improved the generate_parameter_library parameter declaration file.