Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite mimic joints #297

Merged
merged 24 commits into from
Apr 23, 2024
Merged

Rewrite mimic joints #297

merged 24 commits into from
Apr 23, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 7, 2024

The component_parser of the resource_manager now already parses the mimic joint information from the URDF. The old way for defining it in the ros2_control tag is deprecated, see ros-controls/ros2_control#1256.

If this one is approved, I'll make the same changes for gz_ros2_control as well.

$ ros2 control list_hardware_interfaces
command interfaces
        right_finger_joint/position [available] [claimed]
state interfaces
        left_finger_joint/effort
        left_finger_joint/position
        left_finger_joint/velocity
        right_finger_joint/effort
        right_finger_joint/position
        right_finger_joint/velocity

image

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR overall looks good to me. Thanks for the changes. I left few comments for clarification

doc/index.rst Outdated Show resolved Hide resolved
gazebo_ros2_control/src/gazebo_system.cpp Outdated Show resolved Hide resolved
gazebo_ros2_control/src/gazebo_system.cpp Outdated Show resolved Hide resolved
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the changes :)

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM, just two minor comments

doc/index.rst Outdated Show resolved Hide resolved
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde merged commit 7b17bcc into master Apr 23, 2024
2 of 5 checks passed
@ahcorde ahcorde deleted the mimic_joints_rewrite branch April 23, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"_mimic" joint interface name suffix causes Moveit2 "Joint not found" Error
3 participants