Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AsyncFunctionHandler] Add exception handling #172

Merged

Conversation

saikishor
Copy link
Member

Right now, the async function handler doesn't work well when the exceptions are then in the callback and this might be an issue that we might face in the short term.

This PR addresses this issue by handling the exceptions and throw in the thread that calls trigger_async_callback, so that the main thread is aware of the exception and handle it properly

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (7bd84f6) to head (bf05c0b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   80.39%   81.26%   +0.87%     
==========================================
  Files           8        8              
  Lines         306      315       +9     
  Branches       53       54       +1     
==========================================
+ Hits          246      256      +10     
  Misses         25       25              
+ Partials       35       34       -1     
Flag Coverage Δ
unittests 81.26% <100.00%> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/async_function_handler.hpp 91.02% <100.00%> (+2.61%) ⬆️

@saikishor saikishor force-pushed the async_handler/handle/exceptions branch from 0793ba8 to 060e907 Compare September 13, 2024 16:51
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and clean.

@bmagyar bmagyar merged commit 144b12c into ros-controls:master Oct 28, 2024
26 checks passed
@saikishor saikishor deleted the async_handler/handle/exceptions branch October 28, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants