Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add joint interfaces and transmission design draft #15

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Apr 6, 2020

No description provided.

</transmission>
```
The content of a `hardwareInterface` XML attribute should match up with strings provided by `ros2_control` in the shape of familiar names:
`hardware_interface::PositionJointInterface, hardware_interface::VelocityJointInterface, hardware_interface::EffortJointInterface`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should reconsider this, since we are not sure exactly how those interfaces will be implemented in robot_hardware. By using MultiInterfaceJointState we are more flexible.

Also, we need to clarify the terms Joint and Actuator so they are the same in the whole framework, especially in the hardware_interface package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only to highlight the use of standard names with a simple proposal, of course they can be changed but let's do that in a follow-up PR

### RobotHardware

```
void RobotHardware::declareInterface(string name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check how to do this exactly. This is a possible way, but for registering new Actuators which than have an instance of Transmission class in them.

@bmagyar bmagyar force-pushed the add-joint-interfaces-and-transmission-design branch from 0abd8b8 to c59f6e5 Compare April 21, 2020 09:05
@bmagyar
Copy link
Member Author

bmagyar commented Apr 23, 2020

@destogl I'll merge thsi and please open PR-s with suggested changes

@bmagyar bmagyar merged commit 8332aaf into master Apr 23, 2020
@bmagyar bmagyar deleted the add-joint-interfaces-and-transmission-design branch August 4, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants