Import ros2_control

[Karsten1987]

Top Level issue referencing all pending PRs

[bmagyar]

Thanks Karsten! All merged and ready to demo ;)

Even though it is only demo mode I have one comment that should be sorted: visibility_control.h is duplicated in all packages. This is something that should make it into a core ROS2 package and probably even included with a #include <ros2/ros2.h>

[bmagyar]

@Karsten1987 Please add a short summary & steps to compile and set up to the readme .

[chapulina]

As indicated on the README, the code in this repository is still a proof of concept. It may be worth it ticketing issues listing what's left for this to be recommended for use. Will there be a Crystal release?

[bmagyar]

We don't have anyone currently working on ros2_control but we'd gladly welcome merge requests or even a new maintainer for that role. It wouldn't take more than an hours worth of meeting to come up with a roadmap that goes beyond the proof of concept.

I personally won't be able to dedicate time to it until next year.

[GavinStrunk]

@bmagyar @chapulina Hey I have been looking at this repo thinking I would be interested in contributing and maintaining it. I would definitely like some help in terms of defining a roadmap, because it is a little unclear to me what people would like out of this compared to ros_controls beyond using some of the new functionality in ros2. Do you have a recommendation on how people have setup this type of meeting in the past?

[chapulina]

Maybe a discourse post with some ideas and asking for feedback from the community could be a good starting point. It would also be nice to describe the current state of the code and what's missing - maybe @Karsten1987 has the most context?

[bmagyar]

We'd like to move much of the existing codebase under ros2_control. Can we get a hangouts together with the three of us?

…

On Fri, 16 Nov 2018, 17:52 chapulina ***@***.*** wrote: Maybe a discourse post with some ideas and asking for feedback from the community could be a good starting point. It would also be nice to describe the current state of the code and what's missing - maybe @Karsten1987 <https://github.com/Karsten1987> has the most context? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADXH4fH2y_4NbRQgKPcFiO_gGZcoJkRyks5uvvtngaJpZM4PZKQY> .

[GavinStrunk]

Yea sounds good to me. I'm pretty flexible in the next week so if there is a day and time that works for both of you I can make it work. I'm on Eastern US time zone.

[chapulina]

I'm mainly interested in knowing the roadmap so that we can plan porting gazebo_ros_control accordingly. I've actually never used ros_control, so I think I'd be of little help to you 😬