Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting of initial state in HW compoments #1046

Merged
merged 9 commits into from
Jun 23, 2023
Merged

Enable setting of initial state in HW compoments #1046

merged 9 commits into from
Jun 23, 2023

Conversation

destogl
Copy link
Member

@destogl destogl commented Jun 5, 2023

This is the cleaned verison proposed in:

ros-controls/ros2_control_demos#277

Solves first part of #1045

@destogl destogl self-assigned this Jun 5, 2023
@destogl destogl mentioned this pull request Jun 5, 2023
Open
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023 •
edited
Loading

Codecov Report

Merging #1046 (7ea83fa) into master (925f5f3) will decrease coverage by 2.28%.
The diff coverage is 35.06%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
- Coverage   34.61%   32.34%   -2.28%     
==========================================
  Files          52       93      +41     
  Lines        2981     9833    +6852     
  Branches     1855     6628    +4773     
==========================================
+ Hits         1032     3180    +2148     
- Misses        310      778     +468     
- Partials     1639     5875    +4236
Flag Coverage Δ
unittests 32.34% <35.06%> (-2.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 37.83% <ø> (-1.88%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 47.68% <ø> (-5.94%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.42% <ø> (ø)
... and 70 more

... and 19 files with indirect coverage changes

@destogl destogl added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Jun 5, 2023
@destogl destogl removed the bug label Jun 12, 2023
bmagyar
bmagyar reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THe only comment is regarding duplicating vs reworking the tests. Let's duplicate while the functionality is still there (we had issues with this before)

christophfroehlich
christophfroehlich approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine for me now

@bmagyar bmagyar merged commit cf4448d into master Jun 23, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Jun 23, 2023
@destogl @mergify
Enable setting of initial state in HW compoments (#1046)
f2ac6d7 
(cherry picked from commit cf4448d)

# Conflicts:
#	controller_manager/src/controller_manager.cpp
#	hardware_interface/include/hardware_interface/resource_manager.hpp
#	hardware_interface/src/resource_manager.cpp
@mergify mergify bot mentioned this pull request Jun 23, 2023
Merged
@bmagyar bmagyar deleted the hw-components-initial-state branch December 4, 2023 10:43
destogl pushed a commit that referenced this pull request Jan 22, 2024
@mergify
Enable setting of initial state in HW components (backport #1046) (#1064
2d31b1b 
)

(cherry picked from commit cf4448d)


---------
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@bmagyar bmagyar bmagyar approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@jackcenter jackcenter Awaiting requested review from jackcenter

@livanov93 livanov93 Awaiting requested review from livanov93

@LukasMacha97 LukasMacha97 Awaiting requested review from LukasMacha97

@malapatiravi malapatiravi Awaiting requested review from malapatiravi

Assignees

@destogl destogl

Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@destogl @codecov-commenter @christophfroehlich @bmagyar