Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix controller sorting issue while loading large number of controllers #1180

Merged
merged 7 commits into from
Dec 3, 2023
Merged

Fix controller sorting issue while loading large number of controllers #1180

merged 7 commits into from
Dec 3, 2023

Commits on Nov 27, 2023

  1. added test to reproduce the behavior of crashing on large number of c… 

    …ontrollers (ros-controls#1170)
    @saikishor
    saikishor committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    008ae6f View commit details
    Browse the repository at this point in the history

  2. Added tests for complex scenarios such as every joint has a chainable… 

    … controller used by a couple of controllers
    @saikishor
    saikishor committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    47516f3 View commit details
    Browse the repository at this point in the history

  3. fix the bug in the test controller chain formulation

    @saikishor
    saikishor committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    cfc5cdd View commit details
    Browse the repository at this point in the history

  4. switch to stable_sort to avoid crashing on edge cases

    @saikishor
    saikishor committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    16cdd84 View commit details
    Browse the repository at this point in the history

  5. fix the sorting logic for complex and large use-cases (fixes ros-cont… 

    …rols#1170)
    @saikishor
    saikishor committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2e32546 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Add 20 broadcasters + 20 normal controllers to large_chained_controll… 

    …er_tree test + renaming variables
    @saikishor
    saikishor committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    65bdba0 View commit details
    Browse the repository at this point in the history

  2. simplifying the sorting logic

    @saikishor
    saikishor committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    aa12d26 View commit details
    Browse the repository at this point in the history