[CI] Increase timeout for controller_managers_srv test #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
github-actions
bot
requested review from
aprotyas,
bmagyar,
destogl,
jaron-l,
progtologist,
saikishor and
VX792
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1224 +/- ##
=======================================
Coverage 47.65% 47.65%
=======================================
Files 40 40
Lines 3448 3448
Branches 1867 1867
=======================================
Hits 1643 1643
Misses 480 480
Partials 1325 1325
Flags with carried forward coverage won't be shown. Click here to find out more. |
aprotyas
approved these changes
Dec 17, 2023
destogl
approved these changes
Dec 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2023
(cherry picked from commit 82c82ae) # Conflicts: # controller_manager/CMakeLists.txt
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2023
(cherry picked from commit 82c82ae)
bmagyar
pushed a commit
that referenced
this pull request
Dec 17, 2023
bmagyar
pushed a commit
that referenced
this pull request
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1180 the CI runs into the default 60s timeout of the test, see e.g., here.
I'd increase it to 120s, let's see if this is sufficient.