Issue #1235: improve transmission tests #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
bmagyar,
christophfroehlich,
destogl,
progtologist,
saikishor and
VanshGehlot
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1238 +/- ##
=======================================
Coverage 47.82% 47.82%
=======================================
Files 40 40
Lines 3448 3448
Branches 1869 1869
=======================================
Hits 1649 1649
+ Misses 456 455 -1
- Partials 1343 1344 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
taDachs
force-pushed
the
issue-1235-improve-transmission-tests
branch
from
b8af0a1
to
73e6658
Compare
|
I don't really understand why the binary/rolling workflow failed, but it seems like it doesn't directly relate to my code changes? |
bmagyar
approved these changes
Dec 20, 2023
|
That failure has nothing to do with your changes. It failed for a similar reason this PR exists, test instability! ;) |
bmagyar
added
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
* [transmission_interface] relaxes float tolerance in tests * [transmission_interface] replaces EXPECT_EQ for floats with EXPECT_THAT(..., DoubleNear(...)) (cherry picked from commit e92b6c2)
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
* [transmission_interface] relaxes float tolerance in tests * [transmission_interface] replaces EXPECT_EQ for floats with EXPECT_THAT(..., DoubleNear(...)) (cherry picked from commit e92b6c2)
8 tasks
8 tasks
bmagyar
pushed a commit
that referenced
this pull request
Dec 22, 2023
bmagyar
pushed a commit
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
EXPECT_EQwithEXPECT_THAT(..., DoubleNear(...))for floats, as well as relaxes the usedEPSfrom 1e-6 to 1e-5 as mentioned in #1235 . I also replaced theEXPECT_NEARthe same way for consistency. I skippedtest_transmission_parser.cppas I doesn't seem to be build, but I can adapt it in the same way if wanted.