[CONCEPT: DO NOT MERGE] Add data tamer to log command interface values #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
pac48
force-pushed
the
pr-add-data-tamer-logging
branch
from
80336d8
to
0f40bf4
Compare
pac48
force-pushed
the
pr-add-data-tamer-logging
branch
from
7767843
to
76b4e24
Compare
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
pac48
force-pushed
the
pr-add-data-tamer-logging
branch
from
76b4e24
to
c39b1ba
Compare
6 tasks
|
@pac48, all pull requests must be targeted towards the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be very helpful if we could visualize/plot the commands sent to the robot over time. I found combining data_tamer and PlotJuggler to be an effective and easy-to-integrate solution. I made this PR to demonstrate one way it can be integrated, but I think this concept is worth some discussion. Here are some screenshots using the JTC and mock Panda robot.