-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the multiple definitions of lexical casts methods #1281
Merged
bmagyar
merged 1 commit into
ros-controls:master
from
saikishor:fix_multiple_definitions_of_lexical_casts
Jan 9, 2024
Merged
fix the multiple definitions of lexical casts methods #1281
bmagyar
merged 1 commit into
ros-controls:master
from
saikishor:fix_multiple_definitions_of_lexical_casts
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
fmauch,
livanov93,
moriarty and
olivier-stasse
January 9, 2024 09:19
This was referenced Jan 9, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1281 +/- ##
==========================================
- Coverage 47.89% 47.87% -0.03%
==========================================
Files 41 41
Lines 3451 3453 +2
Branches 1876 1878 +2
==========================================
Hits 1653 1653
Misses 444 444
- Partials 1354 1356 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Jan 9, 2024
bmagyar
added
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
labels
Jan 9, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
(cherry picked from commit 71506d5)
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
(cherry picked from commit 71506d5)
This was referenced Jan 9, 2024
bmagyar
pushed a commit
that referenced
this pull request
Jan 9, 2024
bmagyar
pushed a commit
that referenced
this pull request
Jan 9, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue caused in the PR : ros-controls/ros2_control_demos#428
When you have multiple files using the lexical casts header and they create the same library/executable, they show this multiple definitions error