Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test_components to own package (backport #1325) #1340

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 25, 2024

This is an automatic backport of pull request #1325 done by Mergify.
Cherry-pick of 0bdcd41 has failed:

On branch mergify/bp/humble/pr-1325
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 0bdcd41.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/ci-ros-lint.yml
	new file:   hardware_interface_testing/CMakeLists.txt
	new file:   hardware_interface_testing/README.md
	new file:   hardware_interface_testing/package.xml
	renamed:    hardware_interface/test/test_components/test_actuator.cpp -> hardware_interface_testing/test/test_components/test_actuator.cpp
	renamed:    hardware_interface/test/test_components/test_components.xml -> hardware_interface_testing/test/test_components/test_components.xml
	renamed:    hardware_interface/test/test_components/test_sensor.cpp -> hardware_interface_testing/test/test_components/test_sensor.cpp
	renamed:    hardware_interface/test/test_components/test_system.cpp -> hardware_interface_testing/test/test_components/test_system.cpp
	renamed:    hardware_interface/test/test_resource_manager.cpp -> hardware_interface_testing/test/test_resource_manager.cpp
	renamed:    hardware_interface/test/test_resource_manager.hpp -> hardware_interface_testing/test/test_resource_manager.hpp
	renamed:    hardware_interface/test/test_resource_manager_prepare_perform_switch.cpp -> hardware_interface_testing/test/test_resource_manager_prepare_perform_switch.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/ci-coverage-build.yml
	both modified:   controller_manager/package.xml
	both modified:   hardware_interface/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 0bdcd41)

# Conflicts:
#	.github/workflows/ci-coverage-build.yml
#	controller_manager/package.xml
#	hardware_interface/CMakeLists.txt
@mergify mergify bot added the conflicts label Jan 25, 2024
.github/workflows/ci-coverage-build.yml Outdated Show resolved Hide resolved
controller_manager/package.xml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (dc7b7be) 31.14% compared to head (3bb868a) 31.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1340      +/-   ##
==========================================
- Coverage   31.14%   31.03%   -0.11%     
==========================================
  Files          95       95              
  Lines       10731    10729       -2     
  Branches     7421     7421              
==========================================
- Hits         3342     3330      -12     
- Misses        715      723       +8     
- Partials     6674     6676       +2     
Flag Coverage Δ
unittests 31.03% <18.75%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ace_testing/test/test_components/test_actuator.cpp 68.88% <ø> (ø)
...rface_testing/test/test_components/test_sensor.cpp 73.68% <ø> (ø)
...rface_testing/test/test_components/test_system.cpp 61.36% <ø> (ø)
...e_interface_testing/test/test_resource_manager.hpp 72.22% <ø> (ø)
...t/test_resource_manager_prepare_perform_switch.cpp 7.76% <ø> (ø)
...e_interface_testing/test/test_resource_manager.cpp 28.52% <18.75%> (ø)

... and 5 files with indirect coverage changes

@destogl destogl merged commit 9bab433 into humble Jan 26, 2024
14 of 15 checks passed
@destogl destogl deleted the mergify/bp/humble/pr-1325 branch January 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants