Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Code coverage + pre-commit #1413

Merged
merged 5 commits into from
Feb 25, 2024
Merged

[CI] Code coverage + pre-commit #1413

merged 5 commits into from
Feb 25, 2024

Conversation

christophfroehlich
Copy link
Contributor

  • Use coverage workflows from ros2_control_ci
  • Use pre-commit workflow from ros2_control_ci (combines old format and lint job)
  • Fix pre-commit errors

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Feb 23, 2024
fmauch
fmauch approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing those smaller quirks on the way :-)

@bmagyar bmagyar merged commit 1538c91 into ros-controls:master Feb 25, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
@christophfroehlich @mergify
[CI] Code coverage + pre-commit (#1413)
b20b149 
(cherry picked from commit 1538c91)

# Conflicts:
#	.github/workflows/ci-coverage-build.yml
#	.github/workflows/ci-format.yml
#	.github/workflows/ci-ros-lint.yml
#	.pre-commit-config.yaml
@mergify mergify bot mentioned this pull request Feb 25, 2024
Merged
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
@christophfroehlich @mergify
[CI] Code coverage + pre-commit (#1413)
84230a2 
(cherry picked from commit 1538c91)

# Conflicts:
#	.github/workflows/ci-coverage-build.yml
#	.github/workflows/ci-ros-lint.yml
#	.pre-commit-config.yaml
@mergify mergify bot mentioned this pull request Feb 25, 2024
Merged
christophfroehlich added a commit that referenced this pull request Feb 26, 2024
@christophfroehlich
[CI] Code coverage + pre-commit (#1413)
8bf7025
christophfroehlich added a commit that referenced this pull request Feb 26, 2024
@christophfroehlich
[CI] Code coverage + pre-commit (#1413)
f21e5da
destogl added a commit that referenced this pull request Feb 28, 2024
@mergify @christophfroehlich
@bmagyar @destogl
[CI] Code coverage + pre-commit (backport #1413) (#1415)
743e065 
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
bmagyar pushed a commit that referenced this pull request Mar 1, 2024
@mergify
[CI] Code coverage + pre-commit (backport #1413) (#1414)
0aa7ce7
@christophfroehlich christophfroehlich deleted the ci_coverage_precommit branch March 23, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

@bmagyar bmagyar bmagyar approved these changes

@saikishor saikishor saikishor approved these changes

@arne48 arne48 Awaiting requested review from arne48

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@destogl destogl Awaiting requested review from destogl

@mcbed mcbed Awaiting requested review from mcbed

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophfroehlich @fmauch @bmagyar @saikishor