add missing compiler definitions of RCLCPP_VERSION_MAJOR #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
fmauch,
moriarty,
peterdavidfagan and
progtologist
bmagyar
approved these changes
Mar 12, 2024
saikishor
added a commit
to saikishor/ros2_control
that referenced
this pull request
Mar 18, 2024
…-controls#1440)" This reverts commit 09cebfe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for the missing compiler definition flags in PR: #1422, It seems like without those the macros have no effect at all. In rolling, right now it is using the deprecated API. The following changes should fix it.