-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Hardware Components Grouping #1458
[Feature] Hardware Components Grouping #1458
Conversation
The failing tests are due to the Flake8 issue :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for updating the docs as well 😁
4f6d771
to
c357aeb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1458 +/- ##
==========================================
+ Coverage 87.65% 87.70% +0.04%
==========================================
Files 102 102
Lines 8619 8702 +83
Branches 774 780 +6
==========================================
+ Hits 7555 7632 +77
- Misses 788 790 +2
- Partials 276 280 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
This PR allows to have hardware component grouping to allow the components to propagate errors between each other. This is very helpful if the hardware components of one of the actuator of a manipulator fails, we can propagate the error to the rest of the actuators by grouping all their hardware components to one group. In this way, we could avoid continue to execute the motion
Closes #1457