Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustify spawner #1501

Merged
merged 22 commits into from
Aug 16, 2024
Merged

Robustify spawner #1501

merged 22 commits into from
Aug 16, 2024

Commits on Apr 23, 2024

  1. Add integration test with a lot of controller spawners 

    With the current implementation I expect this to fail most of the times.
    @fmauch
    fmauch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    324a012 View commit details
    Browse the repository at this point in the history

  2. Do not wait for controller_manager node 

    This waiting mechanism seems to be very error-prone and is strictly not needed
since we wait for all the services, anyway.

NOTE: This change removes the ability to specify the
controller_manager_timeout.
    @fmauch
    fmauch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7ee0fad View commit details
    Browse the repository at this point in the history

  3. Re-add controller_manager_timeout 

    by setting it as the timeout for the first service call.
    @fmauch
    fmauch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e25ea4f View commit details
    Browse the repository at this point in the history

  4. Resolve deadlock in calling controller_manager services 

    Apparently, sercice calls can end up in a deadlock where the server says
it cannot send the response to the client. In that case, if we spin_until_future_complete()
we will be in a deadlock forever. Hence, this commit adds a timeout and retry
mechanism to the service call abstraction.
    @fmauch
    fmauch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c7bbbb5 View commit details
    Browse the repository at this point in the history

  5. Add missing controllers file

    @fmauch
    fmauch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9b4ecfc View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'master' into robustify_spawner

    @destogl
    destogl authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f26e536 View commit details
    Browse the repository at this point in the history

  2. Update controller_manager/controller_manager/controller_manager_servi… 

    …ces.py
    @destogl
    destogl authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    de424ac View commit details
    Browse the repository at this point in the history

  3. Add call_timeout parameter to service_caller

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    484cd4a View commit details
    Browse the repository at this point in the history

  4. Add documentation to service_caller parameters

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    77f7e16 View commit details
    Browse the repository at this point in the history

  5. Make base_joint a revolute joint

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3e3aded View commit details
    Browse the repository at this point in the history

  6. Use attempt counting with starting from 1

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    85c593c View commit details
    Browse the repository at this point in the history

  7. Add test_dependency on launch_testing_ament_cmake

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a98ca81 View commit details
    Browse the repository at this point in the history

  8. Correct error message on failed service call

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    aa0aa97 View commit details
    Browse the repository at this point in the history

  9. Add more test dependencies

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2120fd8 View commit details
    Browse the repository at this point in the history

  10. Add used controllers to test dependencies

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a77c600 View commit details
    Browse the repository at this point in the history

  11. Do not depend on other controllers

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    14028ea View commit details
    Browse the repository at this point in the history

  12. Reduce installation scope

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    66ac4e8 View commit details
    Browse the repository at this point in the history

  13. Fix test_ros2_control_node.yaml

    @fmauch
    fmauch committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a117f8c View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Use gtest instead of launch_testing for integration test

    @fmauch
    fmauch committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    723a896 View commit details
    Browse the repository at this point in the history

  2. Revert sorting package.xml 

    This is not related to this PR
    @fmauch
    fmauch committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    26262c6 View commit details
    Browse the repository at this point in the history

  3. Revert fixing yaml 

    This is not related to this PR
    @fmauch
    fmauch committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    49137f2 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
    @fmauch @destogl
    fmauch and destogl authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6d627b5 View commit details
    Browse the repository at this point in the history