Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic error in informing user about real-time in ros2_control_node (backport #1726) #1727

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 28, 2024

The logic in informing user about rt capabilities had logic error. User was informed that rt scheduling is set up when in fact is not setup.


This is an automatic backport of pull request #1726 done by Mergify.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.15%. Comparing base (8e33b4e) to head (a60fce7).

Files Patch % Lines
controller_manager/src/ros2_control_node.cpp 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1727      +/-   ##
==========================================
- Coverage   62.17%   62.15%   -0.03%     
==========================================
  Files         109      109              
  Lines       12205    12206       +1     
  Branches     8551     8549       -2     
==========================================
- Hits         7589     7587       -2     
- Misses        867      870       +3     
  Partials     3749     3749              
Flag Coverage Δ
unittests 62.15% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/src/ros2_control_node.cpp 77.41% <0.00%> (-2.59%) ⬇️

... and 1 file with indirect coverage changes

@bmagyar bmagyar merged commit a62d074 into iron Aug 28, 2024
11 of 12 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-1726 branch August 28, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants