Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2controlcli] Fix the missing exported state interface printing #1800

Conversation

saikishor
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (0ba1428) to head (61fd6c4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1800   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files         121      121           
  Lines       11542    11542           
  Branches     1054     1054           
=======================================
  Hits        10023    10023           
  Misses       1144     1144           
  Partials      375      375           
Flag Coverage Δ
unittests 86.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@saikishor saikishor changed the title fix the missing exported state interface printing [ros2controlcli] Fix the missing exported state interface printing Oct 16, 2024
@saikishor saikishor marked this pull request as ready for review October 16, 2024 13:56
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant, thank you!

@bmagyar bmagyar merged commit 0a2838a into ros-controls:master Oct 16, 2024
20 checks passed
@bmagyar
Copy link
Member

bmagyar commented Oct 16, 2024

Linking it to #995 for posterity

@saikishor saikishor deleted the fix/ros2controlcli/missing_exported_state_interfaces branch October 16, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants