-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ros2_control_node] add thread_priority option to the ros2_control_node #1820
[ros2_control_node] add thread_priority option to the ros2_control_node #1820
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1820 +/- ##
==========================================
+ Coverage 87.60% 87.62% +0.02%
==========================================
Files 120 120
Lines 12223 12223
Branches 1093 1093
==========================================
+ Hits 10708 10711 +3
+ Misses 1125 1123 -2
+ Partials 390 389 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I realized that we don't mention the ros2_control_node not even once in the docs. Should we?
I think it's a good idea. It gives some idea on how to instantiate their control stack. |
(cherry picked from commit 832602d) # Conflicts: # controller_manager/src/ros2_control_node.cpp # doc/release_notes.rst
(cherry picked from commit 832602d) # Conflicts: # controller_manager/src/ros2_control_node.cpp # doc/release_notes.rst
Right now, the thread_priority is hard-coded to 50, this PR allows the users to be able to choose their desired priority by setting a parameter at launch time
ros2_control/controller_manager/src/ros2_control_node.cpp
Line 32 in b0da4a1