Fix Hardware spawner and add tests for it (backport #1759) #1828
+333
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically implements my comments from #1682 (review)
I discussed with @destogl that I would create a new PR including his commit from #1682. So, this effectively replaces #1682.
It basically changes the following things:
is_hardware_component_loaded
checks for one single string, whileactivate_components
andconfigure_components
expect a list.)This is an automatic backport of pull request Fix Hardware spawner and add tests for it #1759 done by Mergify.