Handle HW errors on read and write in CM by stopping controllers (backport #742) #abi-breaking #838
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
github-actions
bot
requested review from
bmagyar,
destogl,
duringhof,
harderthan,
jaron-l,
malapatiravi and
rosterloh
destogl
changed the title
destogl
changed the title
destogl
force-pushed
the
mergify/bp/humble/pr-742
branch
from
69e0d38
to
884ebff
Compare
|
Would this be merge to humble with breaking ABI check? |
|
On a scale of 1-10 how much would that bother you? We'd really like to have this in Humble as it's a good quality of life improvement |
|
I would like to have this feature in humble even with breaking abi check. My understanding of this breaking abi could be resolved by updating/fixing the relevant code after it is merged to humble. Is my understanding correct? |
You don't even need to fix the code, but just re-link your libraries. Basically, "recompile" it, beucase compiling and linking is merged togeather with colcon |
destogl
force-pushed
the
mergify/bp/humble/pr-742
branch
from
5de258d
to
64818dd
Compare
|
I see. In this case, I think having this feature available in humble (current LTS release) is an easy decision and a clear winner over holding it. What do you think? |
|
Any thoughts/comments on this PR from the reviewers? |
|
Could the reviewers give this a look and drop your feedback for not approving it? |
Add code for deactivating controller when hardware gets an error on read and write. Fix misleading variable name in the tests. Remove all interface from available list for hardware when an error happens. Do some more variable renaming to the new nomenclature. (cherry picked from commit ecf6c69)
destogl
force-pushed
the
mergify/bp/humble/pr-742
branch
from
64818dd
to
1be9390
Compare
|
Hello @bmagyar and @destogl. I hope you are well We are using the ros2_control in the ROS Humble version in our project and are facing a problem that the modification in #742 will solve. Unfortunately, we can not upgrade our system for the last ROS 2 stable release. Hence, we need this feature in the Humble version. Therefore, do you have some schedule estimation of when this backporting will occur? While this does not happen, do you have any suggestions on how we can handle the hardware component read/write failure for now? In addition, I am available to help you if necessary! |
|
Hi there, just checking in – any updates on this PR? |
|
This pull request is in conflict. Could you fix it @mergify[bot]? |
|
A little complicated to get there but we are making strides
…On Tue, 14 Nov 2023, 07:32 mergify[bot], ***@***.***> wrote:
This pull request is in conflict. Could you fix it @mergify
<https://github.com/mergify>[bot]?
—
Reply to this email directly, view it on GitHub
<#838 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA24PYJ4YPU2RC5Y4YUCVLDYEMM7PAVCNFSM6AAAAAARF7RPUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZGY3TINZYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
needs #1191 first |
github-actions
bot
requested review from
bijoua29,
DasRoteSkelett,
erickisos and
mcbed
|
This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich? |
|
It is too late to merge this PR to Humble at this stage. |
This is an automatic backport of pull request #742 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com