Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing pluginlib xml files for each controller #22

Closed
Karsten1987 opened this issue Feb 20, 2020 · 1 comment · Fixed by #24
Closed

missing pluginlib xml files for each controller #22

Karsten1987 opened this issue Feb 20, 2020 · 1 comment · Fixed by #24
Labels

Comments

@Karsten1987
Copy link
Contributor

Karsten1987 commented Feb 20, 2020

With #19 the individual controllers can't be loaded anymore as the according plugin.xml file is missing.

@jordan-palacios : How did you test to load the controllers in the controller manager? Maybe I am missing something here.

@jordan-palacios
Copy link
Member

@jordan-palacios : How did you test to load the controllers in the controller manager? Maybe I am missing something here.

Controller loading was validated using the test_controller.

There are no tests for controller loading of each individual controller though and I missed adding the plugin.xml files in #19. I'll fix that and also add loading tests for each controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants