Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split controllers into individual packages #19

Merged
merged 7 commits into from
Feb 15, 2020
Merged

Split controllers into individual packages #19

merged 7 commits into from
Feb 15, 2020

Conversation

jordan-palacios
Copy link
Member

Fixes #2.

Also ros_controllers is now a metapackage that depends on all controllers.

@jordan-palacios jordan-palacios marked this pull request as ready for review February 14, 2020 11:50
Karsten1987
Karsten1987 approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

piraka9011
piraka9011 approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Karsten1987 Karsten1987 merged commit 805bd6f into ros-controls:master Feb 15, 2020
@jordan-palacios jordan-palacios deleted the repo_split branch February 17, 2020 08:29
@Karsten1987 Karsten1987 mentioned this pull request Feb 20, 2020
Closed
v-lopez pushed a commit to pal-robotics-forks/ros2_controllers that referenced this pull request Jun 10, 2020
@Karsten1987 @pohzhiee @youtalk
Dashing updates (ros-controls#19)
1f59fe3 
* use dashing rclcpp logger interface

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* use dashing parameter API

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* fixed typo on nullptr check (ros-controls#20)

Fixed a nullptr check typo causing exceptions to be thrown whenever
input command is set to 0.
Signed-off-by: Poh Zhi-Ee <poh140996@hotmail.com>

* remove if/else

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update travis JOB_TYPE

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* Update joint_command_handle.cpp

Co-authored-by: Poh Zhi-Ee <poh140996@hotmail.com>
Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@firesurfer firesurfer mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@piraka9011 piraka9011 piraka9011 approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move controllers to individual packages
3 participants
@jordan-palacios @Karsten1987 @piraka9011