Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of pre-commit hooks #1073

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Bump version of pre-commit hooks #1073

merged 2 commits into from
Mar 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This pull request contains auto-updated files of pre-commit config.

@christophfroehlich christophfroehlich marked this pull request as draft March 11, 2024 10:00
@christophfroehlich christophfroehlich marked this pull request as ready for review March 11, 2024 10:00
@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Mar 11, 2024
@christophfroehlich
Copy link
Contributor

New pre-commit config introduces clang 18, which likes to reformat some parts of the code.

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure whether I would prefer the new formatting, but it seems to be fine.

Than you @christophfroehlich for updating the code.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not bad!

@bmagyar bmagyar merged commit 28cb552 into master Mar 11, 2024
10 of 11 checks passed
@bmagyar bmagyar deleted the auto-update branch March 11, 2024 13:02
mergify bot pushed a commit that referenced this pull request Mar 11, 2024
mergify bot pushed a commit that referenced this pull request Mar 11, 2024
destogl pushed a commit that referenced this pull request Mar 12, 2024
(cherry picked from commit 28cb552)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
destogl pushed a commit that referenced this pull request Mar 12, 2024
(cherry picked from commit 28cb552)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants