Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add jazzy and other minor updates (backport #1114) #1121

Merged
merged 1 commit into from
May 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2024

  • Add Jazzy workflows (I decided to create dedicated files, because it easier to maintain if we branch for jazzy)
  • Add filters to run the ROS - workflows only if code has changed, and the doc workflow only if docs have changed. (branches+path filter have to match both to run the workflow)
  • Check Docs - workflow now uses the correct branch of control.ros.org (not every page is available on every distro any more).
  • Run pre-commit auto-update only once per month
    This is an automatic backport of pull request [CI] Add jazzy and other minor updates #1114 done by Mergify.

* Add file type filters

* Add jazzy workflows and readme

* Check docs on correct branch

* Specify workflow names

* Run auto-update only once per month

* Update upstream pre-commit wf

---------

Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
(cherry picked from commit 4ae8daf)

# Conflicts:
#	.github/workflows/iron-abi-compatibility.yml
#	.github/workflows/rolling-check-docs.yml
@mergify mergify bot added the conflicts label May 8, 2024
Copy link
Contributor Author

mergify bot commented May 8, 2024

Cherry-pick of 4ae8daf has failed:

On branch mergify/bp/humble/pr-1114
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 4ae8daf.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/humble-abi-compatibility.yml
	modified:   .github/workflows/humble-binary-build.yml
	new file:   .github/workflows/humble-check-docs.yml
	modified:   .github/workflows/humble-coverage-build.yml
	modified:   .github/workflows/humble-debian-build.yml
	modified:   .github/workflows/humble-pre-commit.yml
	modified:   .github/workflows/humble-rhel-semi-binary-build.yml
	modified:   .github/workflows/humble-semi-binary-build.yml
	modified:   .github/workflows/humble-source-build.yml
	modified:   .github/workflows/iron-binary-build.yml
	new file:   .github/workflows/iron-check-docs.yml
	modified:   .github/workflows/iron-coverage-build.yml
	modified:   .github/workflows/iron-debian-build.yml
	modified:   .github/workflows/iron-pre-commit.yml
	modified:   .github/workflows/iron-rhel-semi-binary-build.yml
	modified:   .github/workflows/iron-semi-binary-build.yml
	modified:   .github/workflows/iron-source-build.yml
	new file:   .github/workflows/jazzy-abi-compatibility.yml
	new file:   .github/workflows/jazzy-binary-build.yml
	new file:   .github/workflows/jazzy-check-docs.yml
	new file:   .github/workflows/jazzy-coverage-build.yml
	new file:   .github/workflows/jazzy-debian-build.yml
	new file:   .github/workflows/jazzy-pre-commit.yml
	new file:   .github/workflows/jazzy-rhel-semi-binary-build.yml
	new file:   .github/workflows/jazzy-semi-binary-build.yml
	new file:   .github/workflows/jazzy-source-build.yml
	modified:   .github/workflows/rolling-abi-compatibility.yml
	modified:   .github/workflows/rolling-binary-build.yml
	modified:   .github/workflows/rolling-coverage-build.yml
	modified:   .github/workflows/rolling-debian-build.yml
	modified:   .github/workflows/rolling-pre-commit.yml
	modified:   .github/workflows/rolling-rhel-semi-binary-build.yml
	modified:   .github/workflows/rolling-semi-binary-build.yml
	modified:   .github/workflows/rolling-source-build.yml
	modified:   .github/workflows/update-pre-commit.yml
	modified:   README.md
	new file:   ros2_controllers-not-released.jazzy.repos
	new file:   ros2_controllers.jazzy.repos

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/iron-abi-compatibility.yml
	deleted by us:   .github/workflows/rolling-check-docs.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (54bb1e1) to head (74e0dff).

Additional details and impacted files
@@             Coverage Diff             @@
##           humble    #1121       +/-   ##
===========================================
+ Coverage   69.20%   86.72%   +17.51%     
===========================================
  Files          87       86        -1     
  Lines        9564     7593     -1971     
  Branches     6346      618     -5728     
===========================================
- Hits         6619     6585       -34     
+ Misses        789      776       -13     
+ Partials     2156      232     -1924     
Flag Coverage Δ
unittests 86.72% <ø> (+17.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 72 files with indirect coverage changes

@christophfroehlich
Copy link
Contributor

RHEL CI failure is not related to this PR: #1123

@christophfroehlich christophfroehlich merged commit fe07b83 into humble May 8, 2024
12 of 13 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1114 branch May 8, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant