Add parameter check for geometric values (backport #1120) #1126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this post at RSE, I thought it could be a good idea to add simple checks to geometric values of the controllers for mobile robots. For example,
wheel_radius
wheel_base
and others must not be zero ➡️ I added agt<>: [0.0]
validator for them. This also should help if a user misspelled or forgot these parameters.This is an automatic backport of pull request #1120 done by Mergify.