Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter check for geometric values (backport #1120) #1126

Merged
merged 1 commit into from
May 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 9, 2024

Inspired by this post at RSE, I thought it could be a good idea to add simple checks to geometric values of the controllers for mobile robots. For example, wheel_radius wheel_base and others must not be zero ➡️ I added a gt<>: [0.0] validator for them. This also should help if a user misspelled or forgot these parameters.


This is an automatic backport of pull request #1120 done by Mergify.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (067cb0e) to head (7d4f5b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1126      +/-   ##
==========================================
- Coverage   86.63%   86.46%   -0.18%     
==========================================
  Files          86       86              
  Lines        7392     7395       +3     
  Branches      615      613       -2     
==========================================
- Hits         6404     6394      -10     
- Misses        757      772      +15     
+ Partials      231      229       -2     
Flag Coverage Δ
unittests 86.46% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ive_controller/test/test_diff_drive_controller.cpp 93.06% <100.00%> (+0.12%) ⬆️
...cycle_controller/test/test_tricycle_controller.cpp 88.46% <100.00%> (+0.22%) ⬆️

... and 6 files with indirect coverage changes

@bmagyar bmagyar merged commit 70b6807 into iron May 9, 2024
13 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-1120 branch May 9, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants