Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix steering controllers library code documentation and naming (backport #1149) #1164

Merged
merged 1 commit into from
Jun 5, 2024

Commits on Jun 5, 2024

  1. Fix steering controllers library code documentation and naming (#1149)

    * Update documentation and consolidate variable names
    
    * Simplify private methods and further update docs
    
    * Rename methods
    
    * Rename method and variables
    
    * Rename convert method
    
    * Rename variables and improve doc
    
    * Rename local variables
    
    * Use std::isfinite instead of !isnan
    
    Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
    
    * Use a lowercase theta for heading
    
    Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
    
    * Make some temporary variables const
    
    * Let update_from_position call update_from_velocity
    
    * Explicitly set variables with 0 in constructor
    
    * Fix docstring
    
    * Apply consistent variable naming
    
    Co-authored-by:  Quique Llorente <ellorent@redhat.com>
    
    ---------
    
    Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
    Co-authored-by: Quique Llorente <ellorent@redhat.com>
    (cherry picked from commit b245155)
    christophfroehlich authored and mergify[bot] committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    80ef36c View commit details
    Browse the repository at this point in the history