Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault at reconfigure of AdmittanceController (backport #1248) #1265

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 22, 2024

This PR fixes #1181.

I tested it on iron and rebased it on rolling afterwards.

This PR simply avoid recreating the kinematics plugin, but just reinitializes it - which seems to work.


This is an automatic backport of pull request #1248 done by [Mergify](https://mergify.com).

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.26%. Comparing base (3557ed0) to head (126ed15).
Report is 3 commits behind head on humble.

Files Patch % Lines
...ude/admittance_controller/admittance_rule_impl.hpp 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           humble    #1265       +/-   ##
===========================================
- Coverage   87.33%   65.26%   -22.07%     
===========================================
  Files          92      103       +11     
  Lines        8495    11433     +2938     
  Branches      709     7250     +6541     
===========================================
+ Hits         7419     7462       +43     
- Misses        811     1474      +663     
- Partials      265     2497     +2232     
Flag Coverage Δ
unittests 65.26% <0.00%> (-22.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ude/admittance_controller/admittance_rule_impl.hpp 92.66% <0.00%> (-0.86%) ⬇️

... and 88 files with indirect coverage changes

@bmagyar bmagyar merged commit bf53809 into humble Aug 22, 2024
11 of 12 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-1248 branch August 22, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants