Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(steering-odometry): handle infinite turning radius properly #1285

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix(steering-odometry): handle infinite turning radius properly #1285

merged 3 commits into from
Sep 11, 2024

Conversation

reinzor
Copy link
Contributor

@reinzor reinzor commented Sep 10, 2024

No description provided.

reinzor and others added 2 commits September 11, 2024 08:38
@reinzor @saikishor
Update steering_controllers_library/src/steering_odometry.cpp
fdcfe1e 
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
@reinzor @saikishor
Update steering_controllers_library/src/steering_odometry.cpp
7eda2e7 
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
bmagyar
bmagyar approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.34%. Comparing base (c08bdab) to head (7eda2e7).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   80.36%   80.34%   -0.02%     
==========================================
  Files         105      105              
  Lines        9389     9394       +5     
  Branches      827      831       +4     
==========================================
+ Hits         7545     7548       +3     
  Misses       1571     1571              
- Partials      273      275       +2
Flag Coverage Δ
unittests 80.34% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ring_controllers_library/src/steering_odometry.cpp 81.64% <100.00%> (+0.23%) ⬆️

... and 3 files with indirect coverage changes

@bmagyar bmagyar added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Sep 11, 2024
@bmagyar bmagyar merged commit 1dc3d2a into ros-controls:master Sep 11, 2024
12 of 19 checks passed
mergify bot pushed a commit that referenced this pull request Sep 11, 2024
@reinzor @mergify
fix(steering-odometry): handle infinite turning radius properly (#1285)
57f1504 
(cherry picked from commit 1dc3d2a)
@mergify mergify bot mentioned this pull request Sep 11, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 11, 2024
@reinzor @mergify
fix(steering-odometry): handle infinite turning radius properly (#1285)
e3414f5 
(cherry picked from commit 1dc3d2a)
@mergify mergify bot mentioned this pull request Sep 11, 2024
Merged
christophfroehlich pushed a commit that referenced this pull request Sep 12, 2024
@reinzor @christophfroehlich
fix(steering-odometry): handle infinite turning radius properly (#1285)
8cb30fa 
(cherry picked from commit 1dc3d2a)
christophfroehlich pushed a commit that referenced this pull request Sep 12, 2024
@reinzor @christophfroehlich
fix(steering-odometry): handle infinite turning radius properly (#1285)
463bb60 
(cherry picked from commit 1dc3d2a)
christophfroehlich pushed a commit that referenced this pull request Sep 12, 2024
@mergify @reinzor
fix(steering-odometry): handle infinite turning radius properly (#1285)…
1d9c5c3 
… (#1287)

(cherry picked from commit 1dc3d2a)

Co-authored-by: Rein Appeldoorn <reinzor@gmail.com>
christophfroehlich pushed a commit that referenced this pull request Sep 12, 2024
@mergify @reinzor
fix(steering-odometry): handle infinite turning radius properly (#1285)…
448cf43 
… (#1286)

(cherry picked from commit 1dc3d2a)

Co-authored-by: Rein Appeldoorn <reinzor@gmail.com>
RobertWilbrandt pushed a commit to RobertWilbrandt/ros2_controllers that referenced this pull request Sep 19, 2024
@reinzor @RobertWilbrandt
fix(steering-odometry): handle infinite turning radius properly (ros-…
28d47d2 
…controls#1285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor requested changes

@bmagyar bmagyar bmagyar approved these changes

@arne48 arne48 Awaiting requested review from arne48

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@destogl destogl Awaiting requested review from destogl

@fmauch fmauch Awaiting requested review from fmauch

@moriarty moriarty Awaiting requested review from moriarty

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reinzor @bmagyar @saikishor