Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Compilation Issues in joint_trajectory_controller and pid_controller #1329

Closed

Conversation

SENAI-GilmarCorreia
Copy link
Contributor

@SENAI-GilmarCorreia SENAI-GilmarCorreia commented Oct 30, 2024

Description:

This pull request addresses compilation issues encountered in the joint_trajectory_controller and pid_controller when building on Windows. The changes ensure compatibility with the Windows environment and improve overall stability.

Changes Made:

  • joint_trajectory_controller:

    • Updated includes to resolve path issues specific to Windows.
    • Modified conditional compilation flags to ensure compatibility with Windows builds.
  • pid_controller:

    • Fixed issues related to the use of specific libraries that were not resolving correctly on Windows.
    • Added compile definitions for Windows to minimize namespace collisions and define math constants:
      if(WIN32)
        add_compile_definitions(
          # For math constants
          _USE_MATH_DEFINES
          # Minimize Windows namespace collision
          NOMINMAX
          WIN32_LEAN_AND_MEAN
        )
      endif()
    • Ensured that necessary headers are included for successful compilation.

Testing:

  • Local tests have been run successfully, confirming that all modifications do not break existing functionality.
  • New tests have been added to cover the changes made in both controllers, ensuring they work as intended on Windows.

Please let me know if you have any questions or need further modifications. I appreciate your feedback!

Copy link
Contributor

mergify bot commented Oct 30, 2024

@SENAI-GilmarCorreia, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

@christophfroehlich
Copy link
Contributor

closing in favor of #1330 -> we will backport that then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants