Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff drive #18

Closed
wants to merge 2 commits into from
Closed

Add diff drive #18

wants to merge 2 commits into from

Conversation

brightenlee
Copy link

It was ported except for some parts.

@brightenlee brightenlee reopened this Feb 12, 2020
@bmagyar bmagyar changed the base branch from diff-drive to master February 12, 2020 16:32
@bmagyar
Copy link
Member

bmagyar commented Feb 12, 2020

I've changed the target to be master, now we have a proper diff.

Can you elaborate on "except for some parts" please?

@bmagyar bmagyar self-requested a review February 12, 2020 16:33
@brightenlee
Copy link
Author

Importing wheel parameters from URDF and dynamic_reconfigure

@bmagyar
Copy link
Member

bmagyar commented Feb 14, 2020

Thanks! One of the things we'd like to do is to change licensing for Apache 2 as with the rest of ROS2. Would you mind removing your own credits to make life easier? We tend to not claim credits for porting unless it's a substantial rewrite effort.

The plan is to work more on the diff drive port by @piraka9011 hopefully and once all the code is in, have one PR where we get confirmation from all past authors that the license can be changed. All nice and lawyers are happy.

@brightenlee
Copy link
Author

Sure. I'm glad to be able to contribute even a little.

@Karsten1987
Copy link
Contributor

@brightenlee What's the status of this PR? Are you continuing to work on this or can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants