-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JTC] Adding tests for acceleration command interface #752
Merged
bmagyar
merged 6 commits into
ros-controls:master
from
christophfroehlich:jtc_acceleration_tests
Sep 27, 2023
Merged
[JTC] Adding tests for acceleration command interface #752
bmagyar
merged 6 commits into
ros-controls:master
from
christophfroehlich:jtc_acceleration_tests
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #752 +/- ##
==========================================
- Coverage 35.78% 30.88% -4.90%
==========================================
Files 189 7 -182
Lines 17570 832 -16738
Branches 11592 505 -11087
==========================================
- Hits 6287 257 -6030
+ Misses 994 133 -861
+ Partials 10289 442 -9847
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grand!
bmagyar
added
the
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
label
Sep 27, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
(cherry picked from commit f7c13ad)
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Oct 21, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Oct 21, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 11, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 15, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 17, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 27, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 29, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 30, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 5, 2023
bmagyar
pushed a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found todos concerning acceleration tests:
test_jumbled_joint_order
andtest_partial_joint_list
test_jumbled_joint_order
goal.is_same_sign
tois_same_sign_or_zero
Minor changes
std
namespace forcopysign
If someone is thinking about the test trajectory points and the expected outputs of
test_jumbled_joint_order