-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JTC] Make most parameters read-only #771
[JTC] Make most parameters read-only #771
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #771 +/- ##
==========================================
- Coverage 35.78% 30.88% -4.90%
==========================================
Files 189 7 -182
Lines 17570 832 -16738
Branches 11592 505 -11087
==========================================
- Hits 6287 257 -6030
+ Misses 994 133 -861
+ Partials 10289 442 -9847
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5d38539
to
ab48cfd
Compare
9c37cbb
to
f8bf3e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the first part of implementing the suggestions from #394 to JTC.
I made all parameters read-only, which aren't updated anyways or shouldn't be reconfigureable like DoF.
Remaining dynamic parameters (open for discussion):
Changes to get the tests running again: