Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing default int values to double in steering controller's yaml file #927

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Changing default int values to double in steering controller's yaml file #927

merged 5 commits into from
Dec 13, 2023

Conversation

ARK3r
Copy link
Contributor

@ARK3r ARK3r commented Dec 12, 2023

If the previous values were used in a yaml file, they would raise the following errors:

[ros2_control_node-1] [INFO] [1702413712.794005042] [controller_manager]: Loading controller 'bicycle_steering_controller'
[ros2_control_node-1] Exception thrown during controller's init with message: expected [double] got [integer] 
[ros2_control_node-1] [ERROR] [1702413712.817995091] [controller_manager]: Could not initialize the controller named 'bicycle_steering_controller'
[spawner-4] [FATAL] [1702413712.865647530] [spawner_bicycle_steering_controller]: Failed loading controller bicycle_steering_controller

and

[ros2_control_node-1] Exception thrown during controller's init with message: expected [double_array] got [integer_array] 
[ros2_control_node-1] [ERROR] [1702413787.235382487] [controller_manager]: Could not initialize the controller named 'bicycle_steering_controller'
[spawner-4] [FATAL] [1702413787.247119551] [spawner_bicycle_steering_controller]: Failed loading controller bicycle_steering_controller

Changing the values resolved the issue

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Merging #927 (6517a8f) into master (2bcff2f) will increase coverage by 0.56%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
+ Coverage   46.78%   47.35%   +0.56%     
==========================================
  Files          41       41              
  Lines        3862     3862              
  Branches     1816     1816              
==========================================
+ Hits         1807     1829      +22     
+ Misses        801      777      -24     
- Partials     1254     1256       +2
Flag Coverage Δ
unittests 47.35% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

christophfroehlich
christophfroehlich approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Dec 12, 2023
saikishor
saikishor approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bmagyar
bmagyar approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Reza, good catch!

@bmagyar bmagyar merged commit 13a43c3 into ros-controls:master Dec 13, 2023
13 of 15 checks passed
mergify bot pushed a commit that referenced this pull request Dec 13, 2023
@ARK3r @mergify
Changing default int values to double in steering controller's yaml f…
792c6ac 
…ile (#927)

(cherry picked from commit 13a43c3)
mergify bot pushed a commit that referenced this pull request Dec 13, 2023
@ARK3r @mergify
Changing default int values to double in steering controller's yaml f…
20fe90a 
…ile (#927)

(cherry picked from commit 13a43c3)
This was referenced Dec 13, 2023
Merged
Merged
bmagyar pushed a commit that referenced this pull request Dec 18, 2023
@mergify
Changing default int values to double in steering controller's yaml f…
da56cae 
…ile (#927) (#929)
bmagyar pushed a commit that referenced this pull request Dec 18, 2023
@mergify
Changing default int values to double in steering controller's yaml f…
2b92a8c 
…ile (#927) (#928)
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
@VX792
Async params (ros-controls#927)
c1b1865 
* add is_async param to controller manager

* handle is_async param for hw components

* Remove std::terminate() call used for debugging

* Remove whitespace

* Remove empty line

* use strcasecmp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@bmagyar bmagyar bmagyar approved these changes

@saikishor saikishor saikishor approved these changes

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ARK3r @christophfroehlich @bmagyar @saikishor