Revert "[JTC] Remove read_only from 'joints', 'state_interfaces' and 'command_interfaces' parameters (#967)" #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
duringhof,
mcbed,
moriarty and
saikishor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 47.22% 47.61% +0.38%
==========================================
Files 41 41
Lines 3871 3871
Branches 1827 1827
==========================================
+ Hits 1828 1843 +15
+ Misses 775 760 -15
Partials 1268 1268
Flags with carried forward coverage won't be shown. Click here to find out more. |
saikishor
approved these changes
Jan 17, 2024
|
I think this can be merged now as ros-controls/ros2_control#1293 is merged! |
saikishor
added
backport-humble
…'command_interfaces' parameters (ros-controls#967)" This reverts commit 6e2736b.
destogl
approved these changes
Jan 25, 2024
This was referenced Jan 25, 2024
destogl
pushed a commit
that referenced
this pull request
Jan 26, 2024
destogl
pushed a commit
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6e2736b.
This should be merged after ros-controls/ros2_control#1293, which resolves the issue reported in #966.