-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move openni2_launch package into this repository #55
Conversation
see ros-drivers/openni_launch#30 (comment) for a suggestion of keeping indigo-devel the same and migrate only for newer distro to make sure not to break LTS users, people building from source on EOL distros or people relying in the current location of the code. 👍 for keeping the history of migrated files |
Same as ros-drivers/openni_launch#30 (comment), which I am citing below for the record, I suggest to move on with this PR as is. If no concern will be received in a week, I'll merge this.
|
b28a68f
to
6ebf8f6
Compare
@ros-pull-request-builder retest this please |
CI passed except for the one on ROS buildfarm. Its result only says |
This way the defaults for depth processing are set apropriately for both hardware and software registration.
device_id might look like an integer. in that case, getParam() doesn't want to parse the param as a string for some reason (not sure if this is by design). This patch works around that issue.
…low-failure since it's (close to) EOLed. - All pre-release jobs are allow-failure since they are not always necessary (although almost always helpful).
6ebf8f6
to
878398a
Compare
As explained in the question #55 (comment), failed status on Github for ROS buildfarm CI doesn't seem to be critical in this particular case. Merging. |
See detail at ros-drivers/openni2_camera#55 if interested.
See detail at ros-drivers/openni2_camera#55 if interested.
Repository merged into another repo (detail ros-drivers/openni2_camera#55). New releases for IKL from the new repo will become ready to be made, as soon as this PR gets merged. But still we cannot avoid "downtime" of `openni2_launch` in rosdistro. I'll try to stay on alert but if I can't repond, someone with write access to the release repo can make a new release. Artifacts are already pushed so just run: bloom-release --rosdistro indigo --track indigo openni2_camera -p bloom-release --rosdistro kinetic --track kinetic openni2_camera -p bloom-release --rosdistro lunar --track lunar openni2_camera -p
openni2_camera
package only contains node and nodelet library, and I assume most of its users use it viaopenni2.launch
fromopenni2_launch
package, which is maintained in another repo separately. IMO these two repos were separately started during the very early development phase, which made sense at that time. Now that development has slowed down, we can merge two repos into one to reduce maintenance effort.Very similar suggestion is made at ros-drivers/openni_launch#30.
Implementation
I'd suggest simply moving
openni2_launch
pkg intoopenni2_camera
repo, which is already done in this PR. Folder structure:Commit history for the new package should be all preserved from its repo except the merge commits. To retain all commit history, the following set of commands is used (reference):
Future plan for the external repo
Once this PR gets merged, https://github.com/ros-drivers/openni2_launch should be deprecated. Existing issues can be automatically imported into this repo.