Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tf to tf2 #18

Merged
merged 3 commits into from
Nov 18, 2015
Merged

Tf to tf2 #18

merged 3 commits into from
Nov 18, 2015

Conversation

130s
Copy link
Member

@130s 130s commented Nov 17, 2015

Re-opening #16 against jade-devel.
Please review @piyushk

@130s 130s mentioned this pull request Nov 17, 2015
Closed
@piyushk
Copy link
Contributor

piyushk commented Nov 17, 2015

Looks good to me, and I've tested these changes on Indigo. I do not have a Jade system to test these changes.

130s added a commit that referenced this pull request Nov 18, 2015
@130s
Merge pull request #18 from 130s/tf-to-tf2
2222bf2 
Tf to tf2
@130s 130s merged commit 2222bf2 into ros-drivers:jade-devel Nov 18, 2015
@130s 130s deleted the tf-to-tf2 branch November 18, 2015 02:52
@130s
Copy link
Member Author

130s commented Nov 18, 2015

Thanks!
Since this changes interface, I think we need to differentiate version number. I'll bump minor version to 2.2.x for Jade.

@jack-oquin
Copy link
Member

Bumping the minor version in Jade seems reasonable.

@130s 130s mentioned this pull request Sep 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@130s @piyushk @jack-oquin @DaikiMaekawa