Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync noetic to indigo #53

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Conversation

130s
Copy link
Member

@130s 130s commented Oct 26, 2022

Issue aimed at

noetic-devel branch shows 38 commits ahead, 30 commits behind indigo-devel, the current main branch. Since indigo-devel is way EoL and only noetic-devel should be active for now, fixing the outdated noetic-devel by pulling unmerged commits from indigo.

Added changes

Cherry-picked the following unless noted. A lot of cherry-picking turned out empty though.

enable checking launch file validity on test
Enable rostest

Merge pull request ros-drivers#28 from furushchev/prefix

add prefix to nodelet name
@130s
Copy link
Member Author

130s commented Oct 26, 2022

Surprising CI is not enabled for noetic branch?

Merging for now. I'll count on the OSS community for the testing.

@130s 130s merged commit 6da770c into ros-drivers:noetic-devel Oct 26, 2022
@130s 130s deleted the sync-noetic-to-indigo branch October 26, 2022 10:04
@130s
Copy link
Member Author

130s commented Oct 26, 2022

FYI @knorth55 as you seem to be an active user of this pkg.

@knorth55
Copy link
Member

can you change the default branch from indigo-devrl to noetic-devel?

@knorth55
Copy link
Member

noetic test is listed in noetic-devel.

@knorth55
Copy link
Member

@130s can you also check #54?

130s added a commit that referenced this pull request Oct 28, 2022
@130s
Copy link
Member Author

130s commented Oct 28, 2022

can you change the default branch from indigo-devrl to noetic-devel?

Done in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants