Update Github Actions template #752
Conversation
|
@gavanderhoorn: Please have a look |
|
@gavanderhoorn: I you don't have any objection, I will merge this. It is definitely better than the current version. |
doc/industrial_ci_action.yml
Outdated
| # we always want the ccache cache to be persisted, as we cannot easily | ||
| # determine whether dependencies have changed, and ccache will manage | ||
| # updating the cache for us. Adding 'run_id' to the key will force an | ||
| # upload at the end of the job. |
There was a problem hiding this comment.
This is a rather specific comment.
Maybe generalise a bit and just state that we don't use any hashing here to detect whether anything has changed, as ccache itself is capable of detecting whether a cache can be reused. Trying to duplicate that logic here in a GHA config seems like a strange thing to want to do.
For anything not a ccache cache, more complex setups (such as the MoveIt one) would be fully warranted. They're just not part of this simple template.
There was a problem hiding this comment.
Good point! I will rephrase it.
There was a problem hiding this comment.
Of course if the ccache is potentially very large it might make sense to try and optimise it a little (ie: avoid downloading it when it's not needed).
But again: the template shows the 'naive' version, just to get people going.
mathias-luedtke
force-pushed
the
fix/action-template
branch
from
aa749c0
to
59410ed
Compare
closes #590
Based on https://github.com/ros-industrial/fanuc/blob/melodic-devel/.github/workflows/ci_bionic.yml