Fix overlapping properties + allow namespacing #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uploading a different UR definition used to break the previous definition files by overwriting their link lengths. This commit makes the property names for each robot unique so they are independent of the other robot models.
This is the cleaner solution for what the previous commit was meant to solve
…ons' into ur_description_modification
Made include part of the macro for namespacing
…versal_robot into ur_description_modification
added 3 commits
July 26, 2018 14:15
…ersal_robot into ur_description_modification
|
Reviewed and accepted |
|
@ipa-led: similar to #371, this needs a rebase and fixup of the conflicts. |
|
Can be closed, changes already done in this one #356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include PR: #356 from @felixvd
Added a ur.common.xacro file for common macro
Made the include part of the macro to allow namespacing
Checked that xacro produce the same file for both with "--inorder" or without.
Issue : #271