Allow recovery from platform-specific rosdep key errors #308
Conversation
This hook is intended to run before the generator has made any changes to the repository. It can be used to pre-verify such things as rosdep keys or other pre-determined values.
To do this, we override sys.excepthook with a function that calls the old sys.excepthook so the backtrace and exception are printed, but then we invoke sys.exit with the desired return code (or 1 if not specified).
If an action contains the command 'bloom-generate' and returns a specific error code, notify the user that the generator can be skipped and the release can continue without it.
|
Looks good to me, do we have a good example which this can be tested against? Maybe a fake repository which has a rosdep which is defined in one OS but not the other? |
|
You can give it a shot with: This empty package has a dependency on To see the new error handling, try releasing the package for Indigo, or try releasing the package for Hydro and electing to update the action list. Another thing I should have noted is that the packager only has the opportunity to skip the generator if a key exists for other platforms, but not for the target platform. Hopefully this will prevent folks from skipping generation when they legitimately have the wrong rosdep key. |
|
Works for me. |
Allow recovery from platform-specific rosdep key errors
If an action contains the command 'bloom-generate' and returns a specific error code, notify the user that the generator can be skipped and the release can continue without it.
This took some massaging to discover the key resolution error at the right level in bloom before the repository had already been "damaged" by partial generation. As I discuss in the commits, I intruduced a pre-verification step in the form of a
pre_modifyhook in the generators.Commits are grouped logically, please reveiw them all.
Suggested fix for: #296
Thanks,
--scott